Report Node.js ETIMEDOUT as code Unavailable #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
timostamm
changed the title
timostamm
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
I have not been able to trigger this error either.
Code unavailable means:
The service is currently unavailable, usually transiently. Clients should back off and retry idempotent operations.
Node.js documents:
ETIMEDOUT (Operation timed out): A connect or send request failed because the connected party did not properly respond after a period of time.
This is reasonable to map. Thanks for the contribution!
Browserstack CI failure is expected on a fork. The code does not touch @bufbuild/connect-web.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to create a test, but could not figure out how to trigger. It seems to happen when tcp connection cannot be established.