Remove node export condition #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
Feb 13, 2024
timostamm
reviewed
Feb 14, 2024
timostamm
approved these changes
Feb 19, 2024
Merged
alecthomas
referenced
this pull request
in block/ftl
Mar 4, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [@connectrpc/connect](https://github.com/connectrpc/connect-es) ([source](https://github.com/connectrpc/connect-es/tree/HEAD/packages/connect)) | [`1.3.0` -> `1.4.0`](https://renovatebot.com/diffs/npm/@connectrpc%2fconnect/1.3.0/1.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [@connectrpc/connect-web](https://github.com/connectrpc/connect-es) ([source](https://github.com/connectrpc/connect-es/tree/HEAD/packages/connect-web)) | [`1.3.0` -> `1.4.0`](https://renovatebot.com/diffs/npm/@connectrpc%2fconnect-web/1.3.0/1.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [@connectrpc/protoc-gen-connect-es](https://github.com/connectrpc/connect-es) ([source](https://github.com/connectrpc/connect-es/tree/HEAD/packages/protoc-gen-connect-es)) | [`1.3.0` -> `1.4.0`](https://renovatebot.com/diffs/npm/@connectrpc%2fprotoc-gen-connect-es/1.3.0/1.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react)) | [`18.2.58` -> `18.2.61`](https://renovatebot.com/diffs/npm/@types%2freact/18.2.58/18.2.61) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@viz-js/viz](https://github.com/mdaines/viz-js) ([source](https://github.com/mdaines/viz-js/tree/HEAD/packages/viz)) | [`3.3.1` -> `3.4.0`](https://renovatebot.com/diffs/npm/@viz-js%2fviz/3.3.1/3.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [act](https://github.com/nektos/act) | `0.2.59` -> `0.2.60` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | patch | | [autoprefixer](https://github.com/postcss/autoprefixer) | [`10.4.17` -> `10.4.18`](https://renovatebot.com/diffs/npm/autoprefixer/10.4.17/10.4.18) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [github.com/alecthomas/types](https://github.com/alecthomas/types) | `v0.12.1` -> `v0.13.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [postcss-nesting](https://github.com/csstools/postcss-plugins/tree/main/plugins/postcss-nesting#readme) ([source](https://github.com/csstools/postcss-plugins/tree/HEAD/plugins/postcss-nesting)) | [`12.0.3` -> `12.0.4`](https://renovatebot.com/diffs/npm/postcss-nesting/12.0.3/12.0.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [react-router-dom](https://github.com/remix-run/react-router) ([source](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom)) | [`6.22.1` -> `6.22.2`](https://renovatebot.com/diffs/npm/react-router-dom/6.22.1/6.22.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [ch.qos.logback:logback-core](http://logback.qos.ch) ([source](https://github.com/qos-ch/logback), [changelog](https://logback.qos.ch/news.html)) | `1.5.0` -> `1.5.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | compile | patch | | [ch.qos.logback:logback-classic](http://logback.qos.ch) ([source](https://github.com/qos-ch/logback), [changelog](https://logback.qos.ch/news.html)) | `1.5.0` -> `1.5.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | compile | patch | | [io.grpc:grpc-stub](https://github.com/grpc/grpc-java) | `1.61.1` -> `1.62.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | compile | minor | | [io.grpc:grpc-protobuf](https://github.com/grpc/grpc-java) | `1.61.1` -> `1.62.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | compile | minor | | [io.grpc:grpc-netty](https://github.com/grpc/grpc-java) | `1.61.1` -> `1.62.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | compile | minor | --- ### Release Notes <details> <summary>connectrpc/connect-es (@​connectrpc/connect)</summary> ### [`v1.4.0`](https://github.com/connectrpc/connect-es/releases/tag/v1.4.0) [Compare Source](https://github.com/connectrpc/connect-es/compare/v1.3.0...v1.4.0) ##### What's Changed This release includes support for server-side interceptors! Here's a quick example: ```ts import * as http from "http"; import routes from "./connect"; import { connectNodeAdapter } from "@​connectrpc/connect-node"; import type { Interceptor } from "@​connectrpc/connect"; const logger: Interceptor = (next) => async (req) => { console.log(`recevied message on ${req.url}`); return await next(req); }; http .createServer( connectNodeAdapter({ routes, interceptors: [logger], }), ) .listen(8080); ``` For more on them please see the [docs](https://connectrpc.com/docs/node/interceptors). ##### Other Changes - Add service and method in grpc-web unary response by [@​minimal1](https://github.com/minimal1) in [https://github.com/connectrpc/connect-es/pull/984](https://github.com/connectrpc/connect-es/pull/984) - Document the `ts_nocheck` plugin option by [@​timostamm](https://github.com/timostamm) in [https://github.com/connectrpc/connect-es/pull/1012](https://github.com/connectrpc/connect-es/pull/1012) - Remove node export condition by [@​smaye81](https://github.com/smaye81) in [https://github.com/connectrpc/connect-es/pull/1017](https://github.com/connectrpc/connect-es/pull/1017) - Avoid instanceof Message by [@​timostamm](https://github.com/timostamm) in [https://github.com/connectrpc/connect-es/pull/1023](https://github.com/connectrpc/connect-es/pull/1023) ##### New Contributors - [@​minimal1](https://github.com/minimal1) made their first contribution in [https://github.com/connectrpc/connect-es/pull/984](https://github.com/connectrpc/connect-es/pull/984) **Full Changelog**: connectrpc/connect-es@v1.3.0...v1.4.0 </details> <details> <summary>mdaines/viz-js (@​viz-js/viz)</summary> ### [`v3.4.0`](https://github.com/mdaines/viz-js/blob/HEAD/packages/viz/CHANGELOG.md#340) [Compare Source](https://github.com/mdaines/viz-js/compare/b53d0543db4628810823c4307eefc35b9cb4d378...5a5f2312ebf06d3b80036f8aaa006206ceadc858) - Update Graphviz to 10.0.1. </details> <details> <summary>nektos/act (act)</summary> ### [`v0.2.60`](https://github.com/nektos/act/releases/tag/v0.2.60) #### Changelog ##### New Features - [`ac6a465`](https://github.com/nektos/act/commit/ac6a465) feat: Test writing remote Actions locally ([#​2155](https://github.com/nektos/act/issues/2155)) - [`852959e`](https://github.com/nektos/act/commit/852959e) feat: offline mode for new action cache ([#​2173](https://github.com/nektos/act/issues/2173)) ##### Bug fixes - [`e1cd7c9`](https://github.com/nektos/act/commit/e1cd7c9) fix: logo and demo asset urls ([#​2226](https://github.com/nektos/act/issues/2226)) - [`f2e65e1`](https://github.com/nektos/act/commit/f2e65e1) fix: Rootless error concerning `/var/run/docker.sock` ([#​2181](https://github.com/nektos/act/issues/2181)) ##### Other - [`d3c8664`](https://github.com/nektos/act/commit/d3c8664) chore: bump VERSION to 0.2.60 - [`c79f59f`](https://github.com/nektos/act/commit/c79f59f) build(deps): bump go.etcd.io/bbolt from 1.3.8 to 1.3.9 ([#​2229](https://github.com/nektos/act/issues/2229)) - [`68597d6`](https://github.com/nektos/act/commit/68597d6) build(deps): bump github.com/rhysd/actionlint from 1.6.26 to 1.6.27 ([#​2228](https://github.com/nektos/act/issues/2228)) - [`9e6ce12`](https://github.com/nektos/act/commit/9e6ce12) build(deps): bump github.com/opencontainers/image-spec ([#​2223](https://github.com/nektos/act/issues/2223)) - [`5601fb0`](https://github.com/nektos/act/commit/5601fb0) refactor: simpilfy go-git cache ([#​2208](https://github.com/nektos/act/issues/2208)) - [`27eb79b`](https://github.com/nektos/act/commit/27eb79b) build(deps): bump github.com/opencontainers/image-spec ([#​2214](https://github.com/nektos/act/issues/2214)) - [`8277584`](https://github.com/nektos/act/commit/8277584) build(deps): bump golang.org/x/term from 0.16.0 to 0.17.0 ([#​2213](https://github.com/nektos/act/issues/2213)) - [`6e80373`](https://github.com/nektos/act/commit/6e80373) Shrink Readme ([#​2198](https://github.com/nektos/act/issues/2198)) </details> <details> <summary>postcss/autoprefixer (autoprefixer)</summary> ### [`v10.4.18`](https://github.com/postcss/autoprefixer/blob/HEAD/CHANGELOG.md#10418) [Compare Source](https://github.com/postcss/autoprefixer/compare/10.4.17...10.4.18) - Fixed removing `-webkit-box-orient` on `-webkit-line-clamp` ([@​Goodwine](https://github.com/Goodwine)). </details> <details> <summary>alecthomas/types (github.com/alecthomas/types)</summary> ### [`v0.13.0`](https://github.com/alecthomas/types/compare/v0.12.1...v0.13.0) [Compare Source](https://github.com/alecthomas/types/compare/v0.12.1...v0.13.0) </details> <details> <summary>csstools/postcss-plugins (postcss-nesting)</summary> ### [`v12.0.4`](https://github.com/csstools/postcss-plugins/blob/HEAD/plugins/postcss-nesting/CHANGELOG.md#1204) [Compare Source](https://github.com/csstools/postcss-plugins/compare/b69d6de2ff367a17821ba013170229cc8ec5a16c...d1ff1d7bd12327f890df32424ecff32e841dc52b) *February 26, 2024* - Fix order of final CSS with complex usage of both nesting and mixins, by [@​pciarach](https://github.com/pciarach) </details> <details> <summary>remix-run/react-router (react-router-dom)</summary> ### [`v6.22.2`](https://github.com/remix-run/react-router/blob/HEAD/packages/react-router-dom/CHANGELOG.md#6222) [Compare Source](https://github.com/remix-run/react-router/compare/react-router-dom@6.22.1...react-router-dom@6.22.2) ##### Patch Changes - Updated dependencies: - `@remix-run/router@1.15.2` - `react-router@6.22.2` </details> <details> <summary>grpc/grpc-java (io.grpc:grpc-stub)</summary> ### [`v1.62.2`](https://github.com/grpc/grpc-java/releases/tag/v1.62.2) [Compare Source](https://github.com/grpc/grpc-java/compare/v1.61.1...v1.62.2) ##### gRPC Java 1.62.2 Release Notes Note that this is the initial 1.62.x release ##### API Changes - services: Remove `io.grpc.services.BinaryLogs`, which was deprecated since 2021. `io.grpc.protobuf.services.BinaryLogs` should be used instead ([#​10832](https://github.com/grpc/grpc-java/issues/10832)). - Allow users outside of io.grpc.xds package to create custom xDS resources ([#​10834](https://github.com/grpc/grpc-java/issues/10834)) ([`6d96e65`](https://github.com/grpc/grpc-java/commit/6d96e6588)) ##### New Features - api:Add ClientTransportFilter. Similarly to ServerTransportFilter, this will provide an observability hook and it allows direct modification of the transport's attributes. ([#​10646](https://github.com/grpc/grpc-java/issues/10646)) ##### Improvements - java_grpc_library.bzl: Add support for Auto Exec Groups ([`cb03bd2`](https://github.com/grpc/grpc-java/commit/cb03bd234)). This is mostly a behind-the-scenes change to adjust to the newer way Bazel operates - java_grpc_library.bzl: Support runfiles for protoc and the plugin ([`65a6b3b`](https://github.com/grpc/grpc-java/commit/65a6b3bc2)). Neither binary uses runfiles, but the task will be ready if they need to in the future - xds: Add EC key support for XdsChannelCredentials/XdsServerCredentials ([`100d5a5`](https://github.com/grpc/grpc-java/commit/100d5a55f)) - binder:Change log level from WARNING to FINER for expected exception during close with error, to reduce log spamming ([#​10899](https://github.com/grpc/grpc-java/issues/10899)) ([`7ba0718`](https://github.com/grpc/grpc-java/commit/7ba0718bb)) ##### Bug Fixes - xds: Fix a bug in WeightedRoundRobinLoadBalancer policy that could raise NullPointerException and further cause channel panic when picking a subchannel. This bug can only be triggered when connection can not be established and the channel reports TRANSIENT_FAILURE state. ([#​10868](https://github.com/grpc/grpc-java/issues/10868)) ##### Dependencies - The protoc plugin no longer supports macOS Big Sur (macOS 11). Binaries are now built using Monterey (macOS 12) ##### Acknowledgements - [@​joybestourous](https://github.com/joybestourous) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/TBD54566975/ftl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
danroux
pushed a commit
to danroux/sk8l-ui
that referenced
this pull request
May 7, 2024
https://connectrpc.com/docs/node/interceptors Other Changes - Add service and method in grpc-web unary response by @minimal1 in connectrpc/connect-es#984 - Document the ts_nocheck plugin option by @timostamm in connectrpc/connect-es#1012 - Remove node export condition by @smaye81 in connectrpc/connect-es#1017 - Avoid instanceof Message by @timostamm in connectrpc/connect-es#1023
danroux
pushed a commit
to danroux/sk8l-ui
that referenced
this pull request
May 8, 2024
…1.4.0 (#59) https://connectrpc.com/docs/node/interceptors Other Changes - Add service and method in grpc-web unary response by @minimal1 in connectrpc/connect-es#984 - Document the ts_nocheck plugin option by @timostamm in connectrpc/connect-es#1012 - Remove node export condition by @smaye81 in connectrpc/connect-es#1017 - Avoid instanceof Message by @timostamm in connectrpc/connect-es#1023
danroux
pushed a commit
to danroux/sk8l-ui
that referenced
this pull request
May 8, 2024
](https://renovatebot.com){kind=link}
…1.4.0 (#59) https://connectrpc.com/docs/node/interceptors Other Changes - Add service and method in grpc-web unary response by @minimal1 in connectrpc/connect-es#984 - Document the ts_nocheck plugin option by @timostamm in connectrpc/connect-es#1012 - Remove node export condition by @smaye81 in connectrpc/connect-es#1017 - Avoid instanceof Message by @timostamm in connectrpc/connect-es#1023
danroux
pushed a commit
to danroux/sk8l-ui
that referenced
this pull request
May 9, 2024
* npm:(deps-dev): bump @connectrpc/connect-web from 1.3.0 to 1.4.0 https://connectrpc.com/docs/node/interceptors Other Changes - Add service and method in grpc-web unary response by @minimal1 in connectrpc/connect-es#984 - Document the ts_nocheck plugin option by @timostamm in connectrpc/connect-es#1012 - Remove node export condition by @smaye81 in connectrpc/connect-es#1017 - Avoid instanceof Message by @timostamm in connectrpc/connect-es#1023 Bumps [@connectrpc/connect-web](https://github.com/connectrpc/connect-es/tree/HEAD/packages/connect-web) from 1.3.0 to 1.4.0. - [Release notes](https://github.com/connectrpc/connect-es/releases) - [Commits](https://github.com/connectrpc/connect-es/commits/v1.4.0/packages/connect-web) --- updated-dependencies: - dependency-name: "@connectrpc/connect-web" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1014.
In #974, we made a change that removes a common failure point for the dual package hazard. As a result, the
nodeexports condition for our packages should not be necessary and is actually problematic for some bundlers.