Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths in npmignore files #1112

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Fix paths in npmignore files #1112

merged 2 commits into from
Jun 21, 2024

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Jun 19, 2024

Piggybacking on bufbuild/protobuf-es#803, this updates the repo to use .npmignore files everywhere and removes any files settings in package.json files.

Signed-off-by: Steve Ayers <sayers@buf.build>
@smaye81 smaye81 force-pushed the sayers/fix_ignore branch from 351e04b to 2249cd3 Compare June 19, 2024 21:10
@smaye81 smaye81 requested a review from timostamm June 19, 2024 21:10
@smaye81
Copy link
Member Author

smaye81 commented Jun 19, 2024

@timostamm i noticed not every package has an .npmignore file and further, some don't list the src directory. I'm not sure if this was intentional or not. Lmk and I can adjust this PR.

@timostamm
Copy link
Member

Please check with npm pack whether the addition is necessary.

Also see "files" in package.json.

Signed-off-by: Steve Ayers <sayers@buf.build>
@smaye81
Copy link
Member Author

smaye81 commented Jun 20, 2024

@timostamm should be ready to go now.

@smaye81 smaye81 merged commit 1d71dc9 into main Jun 21, 2024
18 checks passed
@smaye81 smaye81 deleted the sayers/fix_ignore branch June 21, 2024 15:22
@timostamm timostamm mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants