Listens to response close event for aborted request trigger on http 1 #1181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1025.
This breaks some backwards compatibility. Up until now the "aborted" state of the request was always set as soon as the body of the request had been read. This is undesired, buggy behavior, as #1025 documents. For any applications using the abort controller's signal, they would be aborted every time!
The Node.js documentation on the request close event is misleading at best, inaccurate at worst, as discussed in nodejs/node#40775. Nevertheless, listening to the
close
event of the response for aborted client requests is the functionally correct implementation. For example, see New Relic changing their instrumentation library to do so newrelic/node-newrelic#1510The exported
universalRequestFromNodeRequest
function now requires theresponse
parameter as well.