Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Browserstack tests to Webdriver #1232

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Sep 13, 2024

This switches our usage of Karma's test runner to Webdriver since Karma's runner is now deprecated.

Closes #810

@smaye81 smaye81 changed the title Sayers/wdio browserstack Switch Browserstack tests to Webdriver Sep 13, 2024
@smaye81 smaye81 force-pushed the sayers/wdio-browserstack branch from 06a54a4 to 3c350d6 Compare September 13, 2024 14:48
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
@smaye81 smaye81 force-pushed the sayers/wdio-browserstack branch from 3c350d6 to f822c19 Compare September 13, 2024 14:49
@smaye81 smaye81 marked this pull request as ready for review September 13, 2024 14:51
@smaye81 smaye81 requested a review from timostamm September 13, 2024 14:54
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just one comment, see below.

.github/workflows/browserstack.yaml Outdated Show resolved Hide resolved
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
@timostamm timostamm merged commit 8bed930 into main Sep 18, 2024
44 of 46 checks passed
@timostamm timostamm deleted the sayers/wdio-browserstack branch September 18, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from the karma test runner for browser tests
3 participants