Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Fix transform for createPromiseClient -> createClient in connect-migrate #1268

Conversation

paul-sachs
Copy link
Contributor

@paul-sachs paul-sachs commented Oct 10, 2024

Existing migration missed a corner case where not all the imports used were to be renamed.

Signed-off-by: Paul Sachs <psachs@buf.build>
@paul-sachs paul-sachs changed the title v2: Add handling of unchanged imports for migration V2: Add handling of unchanged imports for migration Oct 10, 2024
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the bug is that connect-migrate updates imports for createPromiseClient or PromiseClient, but only if the import statement doesn't import anything else.

Thanks for the fix!

@timostamm timostamm changed the title V2: Add handling of unchanged imports for migration V2: Fix transform for createPromiseClient -> createClient in connect-migrate Oct 10, 2024
@timostamm timostamm merged commit 3f95330 into connectrpc:v2 Oct 10, 2024
46 of 49 checks passed
@timostamm timostamm mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants