Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toBinary example in MIGRATING.md #1340

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

HermanBilous
Copy link
Contributor

@HermanBilous HermanBilous commented Nov 25, 2024

toBinary is declared as

export declare function toBinary<Desc extends DescMessage>(schema: Desc, message: MessageShape<Desc>, options?: Partial<BinaryWriteOptions>): Uint8Array;

@timostamm
Copy link
Member

Thanks for the PR, Herman.

I think we already fixed this typo in #1338.

Do we have a link somewhere that points to MIGRATING.md on the v2.0.0 tag? Please let us know if we do, and we'll fix it to point to the main branch instead, where the typo is fixed.

Signed-off-by: Herman Bilous <herman.belous@gmail.com>
@HermanBilous
Copy link
Contributor Author

Hi! I swear I was trying to fix a different line. I updated the pr with correct fix.

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks for the fix Herman!

@timostamm timostamm merged commit dfe3b4f into connectrpc:main Nov 25, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants