Support npm workspaces in set-workspace-version.js #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <ts@timostamm.de>
This was referenced Dec 13, 2024
srikrsna-buf
approved these changes
Dec 17, 2024
timostamm
deleted the
tstamm/Support-npm-workspaces-in-set-workspace-version.js
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates scripts/set-workspace-version.js to use the Node.js v22 glob feature to support npm workspaces. The script requires a package-lock.json file now. Workspace packages can omit a version, but only if they are private.
Also updating the script in connectrpc/connect-query-es#499 and bufbuild/protobuf-es#1036.