New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move compiler option to emit declarations to tsconfig.base.json #1371

Merged

timostamm merged 1 commit into main from tstamm/Move-compiler-option-to-emit-declarations-to-tsconfig.base.json

Dec 19, 2024

Member

timostamm commented Dec 19, 2024

I noticed we made a small improvement in the compiler config in https://github.com/bufbuild/protobuf-es that we don't use here yet:

Instead of passing --declaration to tsc in scripts, we can set "declaration": true in tsconfig.base.json.
Because TypeScript emits declaration files next to the JS files by default, it's redundant to specify --declarationDir in scripts.


          Move compiler option to emit declarations to tsconfig.base.json

a6c29f8

Signed-off-by: Timo Stamm <ts@timostamm.de>

timostamm requested a review from smaye81

December 19, 2024 11:16

srikrsna-buf approved these changes

View reviewed changes

timostamm merged commit ebc1880 into main

45 checks passed

timostamm deleted the tstamm/Move-compiler-option-to-emit-declarations-to-tsconfig.base.json branch

December 19, 2024 13:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet