Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit unpadded base64 for binary headers #454

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Emit unpadded base64 for binary headers #454

merged 1 commit into from
Feb 6, 2023

Conversation

timostamm
Copy link
Member

The Connect protocol asks:

Binary headers must use keys ending in "-bin", and implementations should emit unpadded base64-encoded values. Implementations must accept both padded and unpadded values.

This updates encodeBinaryHeader() to emit unpadded base64-encoded values.

@timostamm timostamm requested a review from smaye81 February 6, 2023 16:17
@timostamm timostamm merged commit b7af363 into main Feb 6, 2023
@timostamm timostamm deleted the tstamm/emit-unpadded-b64 branch February 6, 2023 16:22
@timostamm timostamm mentioned this pull request Feb 17, 2023
Merged
@smaye81 smaye81 mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaye81 smaye81 smaye81 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timostamm @smaye81