Fix the gRPC User-Agent header name #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRPC-web uses X-User-Agent, but gRCP uses the standard header User-Agent. The gRCP transports mistakenly set the X-User-Agent header. This PR corrects that mistake to use User-Agent instead.
smaye81
approved these changes
Mar 13, 2023
Yes, did this in one go, but splitting it up so we have a comprehensible changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gRPC-web protocol uses
X-User-Agent, but gRCP uses the standard headerUser-Agent.The gRCP transports mistakenly set the
X-User-Agentheader, like the gRCP-web transport. This PR corrects that mistake to useUser-Agentinstead.