Abort HTTP/2 streams with RST_STREAM code CANCEL #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gRPC spec asks clients to send an RST_STREAM with code CANCEL for cancelled calls. gRPC servers will surface the gRPC code CANCELLED for such a request.
Our clients simply pass an AbortSignal to the Node.js http2 module, which sends an RST_STREAM with code INTERNAL_ERROR. For better interoperability, this changes our Node.js http2 clients to close streams with code CANCEL when canceled via an AbortSignal.