Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transport options type import #578

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

haines
Copy link
Contributor

@haines haines commented Apr 11, 2023

This PR fixes TypeScript compilation errors introduced in 0.8.5 (#546):

node_modules/@bufbuild/connect-node/dist/types/validate-node-transport-options.d.ts:7:45 - error TS2307: Cannot find module '@bufbuild/connect/src/protocol' or its corresponding type declarations.

7 import type { CommonTransportOptions } from "@bufbuild/connect/src/protocol";
                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@bufbuild/connect-node/dist/types/validate-node-transport-options.d.ts:46:29 - error TS2307: Cannot find module '@bufbuild/connect/src/protocol' or its corresponding type declarations.

46     sendCompression: import("@bufbuild/connect/src/protocol").Compression | null;
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@bufbuild/connect-node/dist/types/validate-node-transport-options.d.ts:47:31 - error TS2307: Cannot find module '@bufbuild/connect/src/protocol' or its corresponding type declarations.

47     acceptCompression: import("@bufbuild/connect/src/protocol").Compression[];
                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@bufbuild/connect-node/dist/types/validate-node-transport-options.d.ts:53:26 - error TS2307: Cannot find module '@bufbuild/connect/src/interceptor.js' or its corresponding type declarations.

53     interceptors: import("@bufbuild/connect/src/interceptor.js").Interceptor[];
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 4 errors.

Signed-off-by: Andrew Haines <andrew@haines.org.nz>
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, Andrew!

@timostamm timostamm merged commit 94f0d4c into connectrpc:main Apr 11, 2023
@haines haines deleted the transport-options-import branch April 11, 2023 12:36
@timostamm timostamm mentioned this pull request Apr 11, 2023
@timostamm
Copy link
Member

This is released in v0.8.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants