Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for timeouts on the server side for all three protocols. This feature from gRPC is also known as deadlines, and it can be used to limit the time a server may take to process a response.
For example, when a client provides the
timeoutMs
call option, a headerConnect-Timeout-Ms
is added to the request. The server parses this timeout, and if it takes longer than the given timeout to process the request, it should give up, and respond with the error codedeadline_exceeded
.On a connect-es server, the parsed timeout is available as an
AbortSignal
on the context:It is up to the implementation to honor the AbortSignal.
This also adds two related options to ConnectRouter:
Edit: The HandlerContext property was originally added as
deadline?: AbortSignal
in this PR, but #531 updated it to besignal: AbortSignal
. The example above was updated.Edit: #632 added a
timeoutMs(): number | undefined
method to the HandlerContext. It can be used to propagate the timeout to upstream RPCs.