Always generate files when no services exist #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
May 1, 2023
There was a problem hiding this comment.
Thank for the update, Sean. We actually don't need the if statement at all - updating the docs in bufbuild/protobuf-es#480. Do you mind removing the if statement completely as suggested in the three generator functions?
sjbarag
force-pushed
the
protoc-gen-connect-es_generate-file-when-no-services-found
branch
from
e67fd1e to
ceeb0cc
Compare
Previously, protoc-gen-connect-es would not emit a file when an input .proto file had no services declared within it. This unfortunately broke the keep_empty_files option, as there was never an empty file to keep. Ensure a file is always generated for each input file, allowing keep_empty_files to determine if it should remain before exiting. fixes connectrpc#597
sjbarag
force-pushed
the
protoc-gen-connect-es_generate-file-when-no-services-found
branch
from
ceeb0cc to
cfd5600
Compare
timostamm
approved these changes
May 2, 2023
sjbarag
deleted the
protoc-gen-connect-es_generate-file-when-no-services-found
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, protoc-gen-connect-es would not emit a file when an input .proto file had no services declared within it. This unfortunately broke the keep_empty_files option, as there was never an empty file to keep. Ensure a file is always generated for each input file, allowing keep_empty_files to determine if it should remain before exiting.
fixes #597