Close the session on error in client transports #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
commented
May 8, 2023
| @@ -78,6 +80,7 @@ export function createTransport(opt: CommonTransportOptions): Transport { | |||
| opt.jsonOptions, | |||
| opt | |||
| ); | |||
| const ac = createLinkedAbortController(signal); | |||
There was a problem hiding this comment.
This is the relevant change: We create an AbortSignal and pass it to the HTTP client, and we wrap the rest of the Transport logic in a try-catch block and abort the signal on error. For HTTP/2, this closes the stream (and session), for HTTP/1.1 it calls destroy() on request and response.
| !parsedType.stream && | ||
| !parsedType.binary | ||
| ) { | ||
| if (methodKind == MethodKind.Unary && parsedType && !parsedType.stream) { |
There was a problem hiding this comment.
This is an unrelated fix. For Connect unary, we always try to parse an error from the response body if we receive a non-successful HTTP status - not just for JSON, but for protobuf binary as well. This has slipped through our test suite so far, but is covered now.
smaye81
approved these changes
May 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, we close HTTP/2 connections after each request in Node.js.
But because of an oversight, the code handling the close never ran if we encountered an error, for example an unexpected response content type, or just an error encoded in the response body or response trailers of a streaming RPC.