Raise proper Connect error codes for closed streams in handlers #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaye81
approved these changes
May 11, 2023
| http2.connect(server.getUrl(), (session: http2.ClientHttp2Session) => { | ||
| const stream = session.request( | ||
| { | ||
| ":method": "POST", |
There was a problem hiding this comment.
Maybe a dumb question, but should we test `GET' requests also now?
There was a problem hiding this comment.
The server side is not merged yet, cannot add tests for it.
| setTimeout(() => { | ||
| stream.on("error", () => { | ||
| // Closing with _some_ codes raises an ERR_HTTP2_STREAM_ERROR | ||
| // error here. |
There was a problem hiding this comment.
If we don't add this event listener, an error is raised and the tests fail.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #531 and adds more test coverage.
We are making sure that we always trigger the AbortSignal in the HandlerContext when a request is finished, and that the abort reason has the proper Connect error code on Node.js.
This includes the mapping of HTTP/2 REST_STREAM codes to Connect error codes, so that requests canceled on the client trigger the signal of the HandlerContext with Code.Canceled.