Always capture header in ConnectError
#924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Makes sense to me to do the same as connect-go. Looks like a legit fix to me 👍
Can you explain the change for users in the PR description?
One question from me, see comments below.
srikrsna-buf
changed the title
ConnecError for gRPC unary callConnecError
timostamm
approved these changes
Nov 24, 2023
Closed
smaye81
changed the title
ConnecErrorConnectError
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In server streaming for all protocols and unary for gRPC/gRPC-Web if an error occurs after the headers are received
ConnectError.metadatadoesn't include them. Instead they are only part of theonHeadercallback.We change the behavior to always capture header in
ConnectError.This was caught by the new conformance tests for client in #890.