Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use unix-style paths for CodeGeneratorResponses #298

Merged
merged 1 commit into from
Jun 18, 2022
Merged

Always use unix-style paths for CodeGeneratorResponses #298

merged 1 commit into from
Jun 18, 2022

Conversation

bufdev
Copy link
Member

@bufdev bufdev commented Jun 17, 2022

@bufdev bufdev requested a review from akshayjshah June 17, 2022 15:34
akshayjshah
akshayjshah approved these changes Jun 18, 2022
View reviewed changes
Copy link
Member

@akshayjshah akshayjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Didn't know about that part of the API contract.

@bufdev bufdev merged commit 8be1a7c into main Jun 18, 2022
@bufdev bufdev deleted the to-slash branch June 18, 2022 15:33
akshayjshah pushed a commit that referenced this pull request Jul 26, 2023
@bufdev
Always use unix-style paths for CodeGeneratorResponses (#298)
49162ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayjshah akshayjshah akshayjshah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings when running on Windows
2 participants
@bufdev @akshayjshah