Update link for conformance repo #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaye81
commented
Sep 1, 2023
README.md
Outdated
| @@ -170,10 +170,10 @@ Offered under the [Apache 2 license][license]. | |||
| [Buf Studio]: https://buf.build/studio | |||
| [Getting Started]: https://connectrpc.com/docs/go/getting-started | |||
| [blog]: https://buf.build/blog/connect-a-better-grpc | |||
| [connect-crosstest]: https://github.com/bufbuild/connect-crosstest | |||
| [connect-conformance]: https://github.com/connectrpc/conformance | |||
There was a problem hiding this comment.
@akshayjshah do you think this should be conformance or connect-conformance?
There was a problem hiding this comment.
I'd probably vote conformance, but only very slightly / don't have a strong opinion - conformance is sort of weird, but it is consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the link for the conformance repo (fka crosstests). This also changes the connect-web link to connect-es to accurately reflect that repo functionality.
Note - not intended to merge until the crosstest repo is moved.