Report assert errors as t.Error

[emcfarlane]

Internal assert package returns booleans for allowing conditional behaviour but currently can't be used as t.Fatal is called suspending execution. It's also not safe for t.Fatal to be called outside of the main go routine running the test. Use t.Error to report errors instead.

Example:

connect-go/client_ext_test.go

Line 212 in 2be1555

assert.NotZero(a.tb, req.Peer().Addr)

under failure would panic the client or server go routines not the test handlers.