Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer an implicit codec when using the gRPC default #655

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Prefer an implicit codec when using the gRPC default #655

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd14c94
Prefer an implicit codec when using the gRPC default
lrewega Dec 15, 2023
95e6796
Make comment more explicit re: GCP bugs
akshayjshah Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions protocol_grpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,13 @@ func grpcContentTypeFromCodecName(web bool, name string) string {
if web {
return grpcWebContentTypePrefix + name
}
if name == codecNameProto {
// For compatibility with Google Cloud Platform's frontends, prefer an
// implicit default codec. See
// https://github.com/connectrpc/connect-go/pull/655#issuecomment-1915754523
// for details.
return grpcContentTypeDefault
}
return grpcContentTypePrefix + name
}

Expand Down
Loading