Restrict metadata headers in error propagation #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses issues when propagating errors from a client back to a handler. On the client side connect errors will contain transport based metadata headers like `Content-Type`, `Content-Length`, etc. These will break when trying to re-encoding the error. Currently `Content-Type` is always overridden. We now expand this behaviour to include all headers utilised by connect, gRPC or gRPCWeb.
emcfarlane
commented
Mar 14, 2024
emcfarlane
changed the title
jhump
reviewed
Mar 18, 2024
emcfarlane
force-pushed
the
ed/mergeMetadataHeaders
branch
from
d5fc4fc to
d88ddf3
Compare
|
Haven't looked at the logic in depth, but we should explain this behavior in the docs ( |
jhump
reviewed
Mar 19, 2024
jhump
approved these changes
Mar 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues when propagating errors from a client back to a handler. On the client side connect errors will contain all response headers: transport (
Content-Type,Content-Length, etc), protocol and application headers. These could break the transport when trying to re-encode the error or leak sensitive information between services. For any wire errors (errors decoded from a client response) we now disable meta propagation. For other errors we now also restrict the headers propagated.