Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handles JavaScript reserved words #19

Closed
wants to merge 1 commit into from

Conversation

dimitropoulos
Copy link
Contributor

closes #18

It seems like our options are:

  1. throw when trying to serialize identifiers that will result in syntax errors
  2. do something to the identifiers so that they're not syntax errors
  • this will, of course, introduce inconsistencies for special cases where these reserved words have been used
  • I am pretty open minded on what the specific suffix should be.

@dimitropoulos
Copy link
Contributor Author

dimitropoulos commented Mar 28, 2023

closing in favor of #28

As it turned out, this functionality already existed in the prodobuf-es codebase, so we just needed to expose it (and thus not reimplement here)

@dimitropoulos dimitropoulos deleted the dimitri/reserved-words branch March 28, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

const ${localName(method)} can result in a not allowed variable name
1 participant