Ensure createconnectQueryKey validates input types #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
paul-sachs
force-pushed
the
psachs/fix-key-typesafety
branch
from
a4d3773 to
2414529
Compare
Signed-off-by: Paul Sachs <psachs@buf.build>
|
If there's a more typescript-foo way to do this without adding some additional type params, all up for it. |
Merged
paul-sachs
added a commit
that referenced
this pull request
Dec 13, 2024
## What's Changed * Ensure createconnectQueryKey validates input types by @paul-sachs in #493 * Update dependencies to support react 19 by @paul-sachs in #495 **Full Changelog**: v2.0.0...v2.0.1 --------- Signed-off-by: Paul Sachs <psachs@buf.build>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere in the generics for create a connect query key, typescript was losing restrictions on the input field. Breaking up the initialization of the potential params and bringing forward the explicit I and O message params seems to resolve the issue.