Semconv conformance to connect specification #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcarp
changed the title
akshayjshah
approved these changes
Jan 20, 2023
| case grpcProtocol: | ||
| return grpcProtocol | ||
| case connectString: | ||
| return connectProtocol |
There was a problem hiding this comment.
🤷🏽♂️ No objections to this, but I've never quite understood why the extra indirection is worth it if we're only referencing the string in one place.
There was a problem hiding this comment.
tbh I think it's probably just because it looks prettier:
case grpcProtocol:
return grpcProtocol
case connectString:
return connectProtocol
vs
case grpcProtocol:
return grpcProtocol
case "connect":
return connectProtocol
akshayjshah
pushed a commit
that referenced
this pull request
Jul 26, 2023
Conforms to open-telemetry/opentelemetry-specification#3116 Namely: - `buf_connect` is not `connect_rpc` - `status_code` is now `error_code` for `connect_rpc` instances. This means that no attribute is set for success - introduce string consts for grpc, grpcweb connect_rpc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conforms to open-telemetry/opentelemetry-specification#3116
Namely:
buf_connectis notconnect_rpcstatus_codeis nowerror_codeforconnect_rpcinstances. This means that no attribute is set for success