Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix next fee estimation #4179

Merged
merged 6 commits into from
May 9, 2023
Merged

Fix next fee estimation #4179

merged 6 commits into from
May 9, 2023

Conversation

LayneHaber
Copy link
Contributor

Description

Uses pricing of canonical asset any time fees are paid in local or adopted. This is because gelato will not support next assets on their API, and have inconsistent asset support across chains (i.e. mainnet DAI is okay, but BSC DAI is not supported).

Currently blocking execution of transfers where users have paid in these assets.

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes (hopefully) #4140 / #4152

Related pull request(s)

@just-a-node just-a-node self-requested a review May 9, 2023 23:28
@LayneHaber LayneHaber merged commit 5c88af0 into main May 9, 2023
@LayneHaber LayneHaber deleted the fix-next-fee-estimation branch May 9, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants