Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK server prod #4243

Merged
merged 11 commits into from
Jun 2, 2023
Merged

SDK server prod #4243

merged 11 commits into from
Jun 2, 2023

Conversation

carlomazzaferro
Copy link
Contributor

Description

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

@rhlsthrm rhlsthrm changed the title prod SDK server prod May 17, 2023
@just-a-node just-a-node force-pushed the feat/sdd-server-prod branch from 1ca2884 to 1c4ab61 Compare June 1, 2023 19:34
container_port = 8080
loadbalancer_port = 80
cpu = 256
memory = 512
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Is this tier enough for SDK Server in prod ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I am not sure. Will defer to @rhlsthrm

Copy link
Collaborator

@preethamr preethamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@sanchaymittal sanchaymittal self-requested a review June 2, 2023 07:24
@carlomazzaferro carlomazzaferro merged commit 751e12d into main Jun 2, 2023
@carlomazzaferro carlomazzaferro deleted the feat/sdd-server-prod branch June 2, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants