Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build workflow #4269

Merged
merged 3 commits into from
May 19, 2023
Merged

Fix build workflow #4269

merged 3 commits into from
May 19, 2023

Conversation

just-a-node
Copy link
Collaborator

Description

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

LayneHaber
LayneHaber reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@LayneHaber LayneHaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we definitely want to remove the publishing step? I don't see it added anywhere

@just-a-node
Copy link
Collaborator Author

just-a-node commented May 19, 2023 •
edited
Loading

we definitely want to remove the publishing step? I don't see it added anywhere

You mean for the chain abstraction sdk? There was a duplicate action, publish happens here (it's folded in the diff viewer): https://github.com/connext/monorepo/pull/4269/files#diff-22f49dea8896855b65ec7f98c2dccafa1b7317f851952fc98ee59f29d84f8af5R227-R232

@just-a-node just-a-node merged commit 00b0b16 into main May 19, 2023
@just-a-node just-a-node deleted the fix-build-workflow branch May 19, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LayneHaber LayneHaber LayneHaber approved these changes

@preethamr preethamr preethamr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@just-a-node @preethamr @LayneHaber