Sdk server config #4418
Merged
Sdk server config #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-a-node
requested review from
rhlsthrm,
sanchaymittal,
carlomazzaferro and
preethamr
as code owners
LayneHaber
reviewed
Jun 7, 2023
| @@ -40,7 +40,8 @@ locals { | |||
| } | |||
| } | |||
| environment = var.stage | |||
| cache = { | |||
| network = var.environment | |||
There was a problem hiding this comment.
kinda weird that stage == environment and environment == network
doesn't really seem consistent with the other env var usage?
There was a problem hiding this comment.
Yeah this comes from /ops/testnet/prod/backend/variables.tf:
Just how these are defined in ops right now.
preethamr
approved these changes
Jun 7, 2023
rhlsthrm
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sdk server config and boot up to match other agents.
Type of change
High-level change(s) description - from the user's perspective
Related Issue(s)
Fixes
Related pull request(s)