Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4376 message verification fails bc of duplicated missing leaves in the message table #4440

Conversation

liu-zhipeng
Copy link
Contributor

Description

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

rhlsthrm
rhlsthrm previously approved these changes Jun 8, 2023
sanchaymittal
sanchaymittal previously approved these changes Jun 8, 2023
Copy link
Collaborator

@sanchaymittal sanchaymittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! Can we do the same for transfer table as well?

wanglonghong
wanglonghong previously approved these changes Jun 8, 2023
@liu-zhipeng liu-zhipeng dismissed stale reviews from wanglonghong, sanchaymittal, and rhlsthrm via 8878716 June 8, 2023 17:55
@liu-zhipeng liu-zhipeng merged commit 10ceea9 into main Jun 9, 2023
@liu-zhipeng liu-zhipeng deleted the 4376-message-verification-fails-bc-of-duplicatedmissing-leaves-in-the-message-table branch June 9, 2023 01:22
@liu-zhipeng liu-zhipeng mentioned this pull request Jun 9, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message verification fails bc of duplicated/missing leaves in the message table
5 participants