Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3437 checkpoints for carto at scale #4452

Merged
merged 18 commits into from
Jun 13, 2023
Merged

Conversation

liu-zhipeng
Copy link
Contributor

Description

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

Copy link
Collaborator

@rhlsthrm rhlsthrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove xcall changes. Other than that it looks good.

@liu-zhipeng liu-zhipeng requested a review from rhlsthrm June 9, 2023 17:22
Copy link
Collaborator

@rhlsthrm rhlsthrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the xcall processing.

@liu-zhipeng liu-zhipeng requested a review from rhlsthrm June 11, 2023 10:27
rhlsthrm
rhlsthrm previously approved these changes Jun 12, 2023
preethamr
preethamr previously approved these changes Jun 12, 2023
@liu-zhipeng liu-zhipeng dismissed stale reviews from preethamr and rhlsthrm via 93d9ce9 June 13, 2023 00:59
@rhlsthrm rhlsthrm merged commit 3f99361 into main Jun 13, 2023
@rhlsthrm rhlsthrm deleted the 3437-checkpoints-for-carto-at-scale branch June 13, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subgraph checkpoints for cartographer queries won't work at scale
4 participants