Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manage relayer tasks #4785

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

wanglonghong
Copy link
Contributor

Description

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

@wanglonghong wanglonghong linked an issue Aug 7, 2023 that may be closed by this pull request
@wanglonghong wanglonghong marked this pull request as ready for review August 7, 2023 04:17
@sanchaymittal
Copy link
Collaborator

will wait for preetham's approval to for above

@sanchaymittal
Copy link
Collaborator

@preethamr waiting for your review

Copy link
Collaborator

@preethamr preethamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the impact on performance ?

@wanglonghong
Copy link
Contributor Author

What would be the impact on performance ?

Once the task is sent to gelato, it just removes messages from pending list and nonce also increases.
In worst case(out of funds), the task can fail on gelato's end but that batch messages will never picked up because it has been already removed and don't re-add it to pending list

@preethamr
Copy link
Collaborator

In worst case(out of funds), the task can fail on gelato's end but that batch messages will never picked up because it has been already removed and don't re-add it to pending list

This is a possible scenario right ? How would we then retry ?

@wanglonghong
Copy link
Contributor Author

How would we then retry ?

  1. We don't remove the batch from the pending list but we update its status to sent.
  2. In each run, it tries to get the task status thought gelato api.
  3. If Cancelled, it updates the statuses to nonce which means it can be picked up again by lighthouse-prover-pub.
  4. If ExecSuccess, it removes the batch from pending,

@preethamr preethamr merged commit f9540c9 into testnet-prod Aug 16, 2023
@preethamr preethamr deleted the 4772-gelato-task-confirmation branch August 16, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry mechanism issue in lighthouse-prover
4 participants