-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimistic roots v1.1 #4951
Merged
sanchaymittal
merged 37 commits into
connext:staging
from
defi-wonderland:optimistic-roots-1.1
Oct 18, 2023
Merged
Optimistic roots v1.1 #4951
sanchaymittal
merged 37 commits into
connext:staging
from
defi-wonderland:optimistic-roots-1.1
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wonderland/connext-monorepo-private into feat/hub-spoke-save-aggregate-root
3 tasks
sanchaymittal
requested review from
LayneHaber,
rhlsthrm and
liu-zhipeng
as code owners
October 18, 2023 09:56
sanchaymittal
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimistic Roots v1.1
With Optimistic Roots v1.0 we introduced the optimistic system to the Root Manager contract (L1) removing the need of:
Use AMBs to send the inbound roots from Spoke Connectors (L2s) to Root Manager (mainnet)
Calculate the aggregate root on-chain on L1.
With v1.1 we aim to bring the optimistic system on the Spoke Connectors to remove the need of propagating the aggregate root from Root Manager -> Spokes through AMBs.
Type of change
High-level change(s) description - from the user's perspective
Related Issue(s)
Not sure if theres a current issue for it, but current v1 code still has the DOS attack on the
propagate
function. This PR fixes that attack vector.Related pull request(s)