Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimistic roots v1.1 #4951

Merged
merged 37 commits into from
Oct 18, 2023

Conversation

gotzenx
Copy link
Contributor

@gotzenx gotzenx commented Oct 2, 2023

Description

Optimistic Roots v1.1
With Optimistic Roots v1.0 we introduced the optimistic system to the Root Manager contract (L1) removing the need of:
Use AMBs to send the inbound roots from Spoke Connectors (L2s) to Root Manager (mainnet)
Calculate the aggregate root on-chain on L1.

With v1.1 we aim to bring the optimistic system on the Spoke Connectors to remove the need of propagating the aggregate root from Root Manager -> Spokes through AMBs.

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Not sure if theres a current issue for it, but current v1 code still has the DOS attack on the propagate function. This PR fixes that attack vector.

Related pull request(s)

0xng and others added 30 commits September 28, 2023 16:56
…wonderland/connext-monorepo-private into feat/hub-spoke-save-aggregate-root
@sanchaymittal sanchaymittal marked this pull request as ready for review October 18, 2023 09:56
@sanchaymittal sanchaymittal merged commit 93a20f9 into connext:staging Oct 18, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants