Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: support propose service #4991

Merged
merged 1 commit into from
Oct 11, 2023
Merged

config: support propose service #4991

merged 1 commit into from
Oct 11, 2023

Conversation

LayneHaber
Copy link
Contributor

Description

Support propose in config services type for lighthouse

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

@LayneHaber LayneHaber added Enhance 🧘 Issue type: Enhancement Request op-roots labels Oct 11, 2023
@LayneHaber LayneHaber self-assigned this Oct 11, 2023
@LayneHaber LayneHaber mentioned this pull request Oct 11, 2023
Closed
6 tasks
@liu-zhipeng liu-zhipeng merged commit aac21ab into staging Oct 11, 2023
39 checks passed
@liu-zhipeng liu-zhipeng deleted the 4940-config-subtask branch October 11, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liu-zhipeng liu-zhipeng liu-zhipeng approved these changes

@preethamr preethamr Awaiting requested review from preethamr preethamr is a code owner

@wanglonghong wanglonghong Awaiting requested review from wanglonghong

@sanchaymittal sanchaymittal Awaiting requested review from sanchaymittal

@rhlsthrm rhlsthrm Awaiting requested review from rhlsthrm

Assignees

@LayneHaber LayneHaber

Labels
Enhance 🧘 Issue type: Enhancement Request op-roots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LayneHaber @liu-zhipeng