Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add unit tests to lh tasks and helpers #4998

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: add unit tests to lh tasks and helpers #4998

merged 1 commit into from
Oct 12, 2023

Conversation

preethamr
Copy link
Collaborator

Description

Add unit tests to lh tasks and helpers and update packages/agents/lighthouse/.nycrc.json

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

@preethamr preethamr merged commit beda4f5 into staging Oct 12, 2023
44 checks passed
@preethamr preethamr deleted the staging_unit_tests branch October 12, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liu-zhipeng liu-zhipeng liu-zhipeng approved these changes

@wanglonghong wanglonghong Awaiting requested review from wanglonghong

@sanchaymittal sanchaymittal Awaiting requested review from sanchaymittal

@rhlsthrm rhlsthrm Awaiting requested review from rhlsthrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preethamr @liu-zhipeng