Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polish: optimistic roots 1.1 #5036

Merged
merged 40 commits into from
Oct 19, 2023
Merged

polish: optimistic roots 1.1 #5036

merged 40 commits into from
Oct 19, 2023

Conversation

gotzenx
Copy link
Contributor

@gotzenx gotzenx commented Oct 19, 2023

Description

Small changes

  • Reverting github actions changes
  • Indexed events params

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Related pull request(s)

0xng and others added 30 commits September 28, 2023 16:56
@0xng
feat: removing lint (#10)
4bf398e
@gotzenx
feat: root manager new variables (#8)
523ebad
@0xng
feat: adding new variables (#7)
26311e7
@gotzenx
refactor: root manager finalize function (#11)
f5caaf0
@gotzenx
refactor: root manager dequeue function (#15)
46892ad
@0xng
feat: adding optimistic mode to spoke (#12)
619ad6b
@gotzenx
refactor: unify propagate
449f044
@gotzenx
refactor: remove deprecated variable (#18)
ee87ae8
@gotzenx
feat: introduce last count check again (#20)
42b71dc
@0xng
feat:optimistic mode guards (#19)
9d6a918
@gotzenx
feat: guard propagation of root zero (#21)
8f8c64f
@0xng
feat: changing constructor params to struct (#23)
84182cb
@gotzenx
feat: added guard for pause to op functions (#25)
1a20451
@0xng
feat: adding whenNotPaused modifier to propose and finalize (#24)
58d787c
@gotzenx
chore: remove unnecesary setup functions on tests (#26)
46e6431
@gotzenx
fix: event natspec (#28)
98c9c42
@gotzenx
refactor: remove lastCountBeforeOpMode variable (#29)
4fb362b
@0xng
fix: natspec (#31)
f9eeab7
@0xng
fix: removing optimistic mode guard from send (#30)
10e7591
@gotzenx
feat: agg root direct save on hub spoke
bed9d85
@0xng
feat: adding natspec
b006512
@0xng
fix: typo
c5d0a09
@0xng
test: convention fixes
c06ec4a
@0xng
docs: natspec typo
f9c5de4
@0xng
docs: natspect typos
0dc037b
@gotzenx
refactor: mainnet spoke imports
edde95d
@gotzenx
Merge branch 'feat/hub-spoke-save-aggregate-root' of github.com:defi-…
5ff2ff9 
…wonderland/connext-monorepo-private into feat/hub-spoke-save-aggregate-root
@gotzenx
feat: saveAggregateRoot delentes pending root if exists
408ebb2
@0xng
test: adding pending root deletion test
e79e86d
@gotzenx
chore: root manager tests comments
ad72ef7
@gotzenx gotzenx marked this pull request as ready for review October 19, 2023 16:27
@preethamr preethamr merged commit fde57f4 into connext:staging Oct 19, 2023
22 checks passed
@0xDiscotech 0xDiscotech deleted the polish-optimistic-roots-1.1 branch January 18, 2024 18:59
@0xDiscotech 0xDiscotech restored the polish-optimistic-roots-1.1 branch January 18, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xng 0xng 0xng approved these changes

@sanchaymittal sanchaymittal sanchaymittal approved these changes

@preethamr preethamr preethamr approved these changes

@LayneHaber LayneHaber Awaiting requested review from LayneHaber LayneHaber is a code owner

@rhlsthrm rhlsthrm Awaiting requested review from rhlsthrm

@liu-zhipeng liu-zhipeng Awaiting requested review from liu-zhipeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gotzenx @preethamr @sanchaymittal @0xng