Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add signature check to hub and spoke propose #5078

Merged
merged 14 commits into from
Nov 8, 2023
Merged

feat: add signature check to hub and spoke propose #5078

merged 14 commits into from
Nov 8, 2023

Conversation

preethamr
Copy link
Collaborator

Description

Add signature check to hub and spoke propose

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

@preethamr preethamr marked this pull request as draft October 28, 2023 05:35
@preethamr preethamr mentioned this pull request Nov 5, 2023
Closed
3 tasks
@liu-zhipeng liu-zhipeng marked this pull request as ready for review November 7, 2023 14:25
LayneHaber
LayneHaber reviewed Nov 8, 2023
View reviewed changes
packages/deployments/contracts/contracts/core/connext/helpers/RelayerProxy.sol Show resolved Hide resolved
packages/deployments/contracts/contracts/core/connext/helpers/RelayerProxy.sol Outdated Show resolved Hide resolved
packages/deployments/contracts/contracts/core/connext/helpers/RelayerProxy.sol Show resolved Hide resolved
packages/deployments/contracts/contracts/core/connext/helpers/RelayerProxy.sol Outdated Show resolved Hide resolved
packages/deployments/contracts/contracts/core/connext/helpers/RelayerProxy.sol Outdated Show resolved Hide resolved
packages/deployments/contracts/contracts/core/connext/helpers/RelayerProxy.sol Outdated Show resolved Hide resolved
packages/deployments/contracts/contracts/core/connext/helpers/RelayerProxyHub.sol Outdated Show resolved Hide resolved
LayneHaber
LayneHaber previously approved these changes Nov 8, 2023
View reviewed changes
LayneHaber
LayneHaber previously approved these changes Nov 8, 2023
View reviewed changes
liu-zhipeng
liu-zhipeng previously approved these changes Nov 8, 2023
View reviewed changes
@liu-zhipeng liu-zhipeng dismissed stale reviews from LayneHaber and themself via 2e90894 November 8, 2023 14:57
@liu-zhipeng liu-zhipeng merged commit 6efc86b into staging Nov 8, 2023
17 checks passed
@liu-zhipeng liu-zhipeng deleted the relayer_proxy_v11 branch November 8, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xng 0xng 0xng left review comments

@gotzenx gotzenx gotzenx left review comments

@liu-zhipeng liu-zhipeng liu-zhipeng approved these changes

@LayneHaber LayneHaber LayneHaber left review comments

@rhlsthrm rhlsthrm Awaiting requested review from rhlsthrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@preethamr @LayneHaber @liu-zhipeng @gotzenx @0xng