Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ownership script fixes #5099

Merged
merged 13 commits into from
Dec 6, 2023
Merged

Ownership script fixes #5099

merged 13 commits into from
Dec 6, 2023

Conversation

LayneHaber
Copy link
Contributor

Description

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

liu-zhipeng
liu-zhipeng previously approved these changes Nov 8, 2023
@@ -205,15 +220,31 @@ export const transferOwnership = async () => {
// handle separately
continue;
}
await handleOwnership((deployments as Deployment).name, (deployments as Deployment).contract, provider, domain);
if ((deployments as Deployment).name.includes("RelayerProxy")) {
await handleOwnership(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a mapping to config which contract should be transferred to admin /dao?

Base automatically changed from linea-mainnet-deployment to main November 15, 2023 03:05
@liu-zhipeng liu-zhipeng dismissed their stale review November 15, 2023 03:05

The base branch was changed.

@liu-zhipeng liu-zhipeng self-requested a review November 16, 2023 01:32
liu-zhipeng
liu-zhipeng previously approved these changes Nov 16, 2023
@liu-zhipeng liu-zhipeng merged commit 2154714 into main Dec 6, 2023
22 checks passed
@liu-zhipeng liu-zhipeng deleted the ownership-script-fixes branch December 6, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants