Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5076 v11 lh propose signs payloads #5144

Merged
merged 21 commits into from
Nov 10, 2023

Conversation

liu-zhipeng
Copy link
Contributor

Description

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

@@ -1108,6 +1108,17 @@ export const getCurrentFinalizedSnapshot = async (
return snapshot ? convertFromDbSnapshot(snapshot) : undefined;
};

export const getLatestSnapshot = async (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where this helper is used, in LH.

@liu-zhipeng liu-zhipeng marked this pull request as ready for review November 9, 2023 12:42
@liu-zhipeng liu-zhipeng mentioned this pull request Nov 9, 2023
5 tasks
preethamr
preethamr previously approved these changes Nov 9, 2023
Copy link
Collaborator

@preethamr preethamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the comment

@liu-zhipeng liu-zhipeng merged commit f857e3c into staging Nov 10, 2023
22 checks passed
@liu-zhipeng liu-zhipeng deleted the 5076-v11-lh-propose-signs-payloads branch November 10, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants