Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure wait period while using outboundroot #5278

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

preethamr
Copy link
Collaborator

Description

Ensure wait period while using outboundroot in a snapshot.

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes
#5277

Related pull request(s)

Copy link
Contributor

@LayneHaber LayneHaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs some comments around the if statement / added code to illustrate reasoning

wanglonghong
wanglonghong previously approved these changes Dec 5, 2023
@preethamr
Copy link
Collaborator Author

Test failing because of merge from main

@preethamr preethamr merged commit bdd4ba0 into staging Dec 5, 2023
21 of 22 checks passed
@preethamr preethamr deleted the outbound_root_wait_time branch December 5, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants