fix: use snapshot n for proposal #5396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu-zhipeng
previously approved these changes
Dec 20, 2023
liu-zhipeng
previously approved these changes
Dec 20, 2023
wanglonghong
previously approved these changes
Dec 20, 2023
preethamr
dismissed stale reviews from wanglonghong and liu-zhipeng
via
8865221
wanglonghong
previously approved these changes
Dec 20, 2023
LayneHaber
previously approved these changes
Dec 20, 2023
|
probably have to revert the change to the mock |
preethamr
dismissed stale reviews from LayneHaber and wanglonghong
via
4d121f8
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
High-level change(s) description - from the user's perspective
Related Issue(s)
Fixes
Related pull request(s)