feat: get write tx for single message #6003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LayneHaber
requested review from
preethamr,
liu-zhipeng and
wanglonghong
as code owners
liu-zhipeng
reviewed
Apr 9, 2024
packages/agents/lighthouse/src/tasks/processFromRoot/helpers/xlayer.ts
Outdated
Show resolved
Hide resolved
liu-zhipeng
approved these changes
Apr 9, 2024
preethamr
reviewed
Apr 9, 2024
| processorFunctionName: string; | ||
| contractAddress?: string; | ||
| contractAbi?: string[]; | ||
| getWriteTransaction: (params: GetProcessArgsParams) => Promise<WriteTransaction | undefined>; |
There was a problem hiding this comment.
Like this pattern.
Concerned that this might cause regression on other (non- XLayer) changes, since this touches processFromRoot on all chains.
There was a problem hiding this comment.
possible, but that's why I grouped the write tx generation in a single function and kept the original getArgs utils
This reverts commit 07a0d6d.
LayneHaber
commented
Apr 15, 2024
|
coverage issues will be resolved in base branch, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes review comments left in #5926 by:
WriteTransactionfor a single messageWriteTransactionBefore merging, we need to ensure that lighthouse will pick up the spoke messages as well.
Type of change
High-level change(s) description - from the user's perspective
Related Issue(s)
Fixes
Related pull request(s)