5834 x1 for mainnet - Main #6130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repo into 5834-x1-for-mainnet
prathmeshkhandelwal1
requested review from
preethamr,
liu-zhipeng,
wanglonghong,
just-a-node,
LayneHaber and
carlomazzaferro
as code owners
preethamr
reviewed
Apr 29, 2024
I dont think so, as the latest state of |
just-a-node
reviewed
Apr 30, 2024
| @@ -214,9 +215,10 @@ export const XERC20REGISTRY_DOMAIN_ADDRESS: Record<string, string> = { | |||
| "1650553709": "0xcc1ce162fb1d70a377d1542873b1db57f5ff14d1", // base | |||
| "1836016741": "0x689cCB572262e0ca66146FE5Ed5D998543d3AA3B", // mode | |||
| "1935897199": "0x397aEEEDd44f40326f9eB583a1DFB8A7A673C40B", // scroll | |||
| "2020368761": "", // xlayer | |||
There was a problem hiding this comment.
Registry + adapter to be deployed in separate PR?
There was a problem hiding this comment.
yes, Will add it separately in sdk
just-a-node
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feat: Adding x Layer
Type of change
High-level change(s) description - from the user's perspective
Related Issue(s)
Fixes
Related pull request(s)