Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

FM-196: Implement ProposalInterpreter::process for BottomUp #202

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Aug 18, 2023

Closes consensus-shipyard/ipc#308
Depends on #201 and #185

Implements ProposalInterpreter::process method for ChainMessageInterpreter by looking up proposed checkpoints for execution in the ResolvePool and checking that the item is present and resolved, otherwise we don't vote for the proposal.

@aakoshh aakoshh changed the base branch from main to fm-191-exec-bottom-up August 18, 2023 14:46
Copy link
Contributor

@adlrocha adlrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One quick question (and I think I saw a message for this). The checkpoint pool will be garbage collected after a checkpoint execution, right? At this point we know it won't have to be re-proposed anymore.

@aakoshh
Copy link
Contributor Author

aakoshh commented Aug 22, 2023

The checkpoint pool will be garbage collected after a checkpoint execution, right? At this point we know it won't have to be re-proposed anymore.

That's right, when the checkpoint is executed it has to be removed from the resolver pool. Thanks for mentioning this because I have not included this in any of the issue description, just commented on it in the code. I created consensus-shipyard/ipc#227 to track it now.

@aakoshh aakoshh force-pushed the fm-191-exec-bottom-up branch from bd53e3f to 48d9336 Compare August 23, 2023 13:53
Base automatically changed from fm-191-exec-bottom-up to main August 23, 2023 13:53
@aakoshh aakoshh force-pushed the fm-196-bottom-up-process branch from 1e26308 to a0dde3c Compare August 23, 2023 13:55
@aakoshh aakoshh merged commit edf0f4c into main Aug 23, 2023
@aakoshh aakoshh deleted the fm-196-bottom-up-process branch August 23, 2023 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check data availability of checkpoints in ProposalInterpreter::process
2 participants