Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

DOCS: Checkpointing #289

Merged
merged 4 commits into from
Oct 2, 2023
Merged

DOCS: Checkpointing #289

merged 4 commits into from
Oct 2, 2023

Conversation

aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Sep 28, 2023

Created a sequence diagram to showcase checkpointing, as promised in #286 (comment)

Copy link
Contributor

@adlrocha adlrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, @aakoshh. It was long overdue. Thanks!

  • The role of the IPC agent has been removed. It is now a library that Fendermint and the relayer can leverage to directly call the relevant child/parent subnets. It may be better to just remove it from the diagram and depict the relayer and Fendermint directly calling the relevant nodes?

  • Also, it may be also worth having a diagram of how top-down messages are executed (@cryptoAtwill or me can pick this one in a follow-up PR).

@aakoshh aakoshh marked this pull request as draft October 2, 2023 13:04
@aakoshh aakoshh marked this pull request as ready for review October 2, 2023 13:21
@aakoshh aakoshh merged commit 3cbf36c into main Oct 2, 2023
2 checks passed
@aakoshh aakoshh deleted the docs-checkpointing branch October 2, 2023 13:21
@aakoshh
Copy link
Contributor Author

aakoshh commented Oct 2, 2023

The role of the IPC agent has been removed. It is now a library that Fendermint and the relayer can leverage to directly call the relevant child/parent subnets.

Okay, I only went by what happened in the now deprecated PRs where IIRC the agent had its own URL, but I could be wrong on that one. Let's fix the diagram when @cryptoAtwill again introduces the syncer. Until then we can treat this diagram as speculative.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants