This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
add cron fields #64
Closed
add cron fields #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlrocha
suggested changes
Mar 15, 2023
There was a problem hiding this comment.
There was a slight confusion in the genesis epoch. Also, if you don't mind adding genesis_epoch as a parameter in the subnet actor state that it is set to rt.current_epoch() in construction? (this is the one that will be used to set the contruct params of the subnet).
Co-authored-by: adlrocha <adlrocha@tutamail.com>
Co-authored-by: adlrocha <adlrocha@tutamail.com>
* update cron * fix lint --------- Co-authored-by: willesxm <willeslau@gmail.com>
adlrocha
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
LGTM, thank you for the fixes 🙏
Do you mind taking note of all the changes over data structures we are making, or propagating them directly to a PR on https://github.com/consensus-shipyard/go-ipc-types? That way we don't end up with inconsistencies and serialization errors as we had we list-subnets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
cron_periodandgenesis_epochto the state and constructor paramUpdates:
genesis_epochin gateway constructor paramgenesis_epochusing current epoch in subnet actorTests
Issues
apply_msgmethod to becomebottom_up_apply_msg#72