Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

RF: Separate e2e testing crate #153

Merged
merged 3 commits into from
Apr 20, 2023
Merged

RF: Separate e2e testing crate #153

merged 3 commits into from
Apr 20, 2023

Conversation

aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Apr 12, 2023

The PR creates a testing/e2e crate called ipc_e2e to hold all end-to-end tests which rely on the external processes running, and currently need to be excluded on CI; this allows us to run all other kinds of stand-alone integration tests.

  • moves tests/common/mod.rs to testing/e2e/src/lib.rs to make it reusable for all tests
  • moves tests/subnet_lifecycle.rs to testing/e2e/tests/subnet_lifecycle.rs
  • make test excludes ipc_e2e but now includes ipld/resolver/tests again
  • make e2e runs ipc_e2e

@aakoshh aakoshh mentioned this pull request Apr 12, 2023
Merged
adlrocha
adlrocha approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@adlrocha adlrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fixed the merge conflicts and will merge. Thanks!

@adlrocha adlrocha merged commit 98c5b83 into main Apr 20, 2023
@adlrocha adlrocha deleted the rf-integration-test-crate branch April 20, 2023 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adlrocha adlrocha adlrocha approved these changes

@cryptoAtwill cryptoAtwill Awaiting requested review from cryptoAtwill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aakoshh @adlrocha