This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Improve formatting of commands and examples #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
reviewed
Apr 20, 2023
aakoshh
reviewed
Apr 20, 2023
aakoshh
reviewed
Apr 20, 2023
aakoshh
approved these changes
Apr 20, 2023
Co-authored-by: Akosh Farkash <aakoshh@gmail.com>
|
Thanks for the review @aakoshh! Changes made, will merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit rushed so some decisions may have been suboptimal given there are some edge cases.
For the now-separate examples, we should add the expected outcome -- which we have in some cases, not in others. But this should already improve quality of life for the reader, so I wouldn't block on re-executing things for output.