-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestions. I haven't looked in depth to the implementation of the functions (only the code structure, as I assumed this just moved code around). Let me know if I should look deeper into something.
Once the comments are addressed, if you have tested it and works feel free to merge.
src/checkpoint/topdown.rs
Outdated
/// The trait that handles the bottom up checkpoint submission data preparation and actual submission. | ||
#[async_trait] | ||
pub trait TopDownHandler: | ||
Send + Sync + VoteQuery<TopDownCheckpoint> + CheckpointUtilQuery<TopDownCheckpoint> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After seeing this, I feel VoteQuery
and CheckpointUtilQuery
can indeed be merged as mentioned above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed CheckpointUtilQuery
to CheckpointQuery
and CheckpointQuery
inherits VoteQuery
.
Refactoring top down checkpoint submission:
TopDownManager
struct that handles the top down checkpoint submission processTopDownHandler
trait that can be implemented bySubnetManager
to provide utility functions forTopDownManager
.checkpoint/fvm
,checkpoint/fevm_fvm
,checkpoint/fevm
folders as they are no longer needed.